search

petegoodliffe / PGMidi

PGMidi iOS MIDI library and example code
297 stars 83 forks source link

Fixed ARC leak bug and MIDI network session bug #6

Closed tkemp closed 9 years ago

tkemp commented 11 years ago

Hi Pete,

Two changes: wrapped an @autorelease scope around the packet transfer code in PGArc.h and fixed a stuck boolean in the network session code. Thanks for this.

Cheers,

Tim

petegoodliffe commented 11 years ago

Many thanks!

Pete

Pete Goodliffe, Principal Software Developer e. pete@goodliffe.net w. www.goodliffe.net s. petegoodliffe

On Wednesday, 21 November 2012 at 16:29, Tim Kemp wrote:

Hi Pete, Two changes: wrapped an @autorelease (https://github.com/autorelease) scope around the packet transfer code in PGArc.h and fixed a stuck boolean in the network session code. Thanks for this. Cheers, Tim You can merge this Pull Request by running: git pull https://github.com/tkemp/PGMidi master Or view, comment on, or merge it at: https://github.com/petegoodliffe/PGMidi/pull/6 Commit Summary Fixed memory leak when receiving packets. Fixed bug where MIDI network sessions were always enabled.

File Changes M Sources/PGMidi/PGArc.h (4) M Sources/PGMidi/PGMidi.mm (2)

Patch Links https://github.com/petegoodliffe/PGMidi/pull/6.patch https://github.com/petegoodliffe/PGMidi/pull/6.diff

— Reply to this email directly or view it on GitHub (https://github.com/petegoodliffe/PGMidi/pull/6).

tkemp commented 11 years ago

You're welcome. As you ask to be told when someone uses it, PGMidi is included in the latest release of my synth WOPR (www.omnivoresoft.com).

On 21 Nov 2012, at 11:35, Pete Goodliffe wrote:

Many thanks!

Pete

Pete Goodliffe, Principal Software Developer e. pete@goodliffe.net w. www.goodliffe.net s. petegoodliffe

On Wednesday, 21 November 2012 at 16:29, Tim Kemp wrote:

Hi Pete, Two changes: wrapped an @autorelease (https://github.com/autorelease) scope around the packet transfer code in PGArc.h and fixed a stuck boolean in the network session code. Thanks for this. Cheers, Tim You can merge this Pull Request by running: git pull https://github.com/tkemp/PGMidi master Or view, comment on, or merge it at: https://github.com/petegoodliffe/PGMidi/pull/6 Commit Summary Fixed memory leak when receiving packets. Fixed bug where MIDI network sessions were always enabled.

File Changes M Sources/PGMidi/PGArc.h (4) M Sources/PGMidi/PGMidi.mm (2)

Patch Links https://github.com/petegoodliffe/PGMidi/pull/6.patch https://github.com/petegoodliffe/PGMidi/pull/6.diff

— Reply to this email directly or view it on GitHub (https://github.com/petegoodliffe/PGMidi/pull/6).

— Reply to this email directly or view it on GitHub.

petegoodliffe commented 11 years ago

Hey, that looks awesome!

Nice work.

Pete Goodliffe, Principal Software Developer e. pete@goodliffe.net w. www.goodliffe.net s. petegoodliffe

On Wednesday, 21 November 2012 at 16:50, Tim Kemp wrote:

You're welcome. As you ask to be told when someone uses it, PGMidi is included in the latest release of my synth WOPR (www.omnivoresoft.com (http://www.omnivoresoft.com)).

On 21 Nov 2012, at 11:35, Pete Goodliffe wrote:

Many thanks!

Pete

Pete Goodliffe, Principal Software Developer
e. pete@goodliffe.net w. www.goodliffe.net (http://www.goodliffe.net) s. petegoodliffe

On Wednesday, 21 November 2012 at 16:29, Tim Kemp wrote:

Hi Pete,
Two changes: wrapped an @autorelease (https://github.com/autorelease) scope around the packet transfer code in PGArc.h and fixed a stuck boolean in the network session code. Thanks for this.
Cheers,
Tim
You can merge this Pull Request by running:
git pull https://github.com/tkemp/PGMidi master
Or view, comment on, or merge it at:
https://github.com/petegoodliffe/PGMidi/pull/6
Commit Summary
Fixed memory leak when receiving packets.
Fixed bug where MIDI network sessions were always enabled.

File Changes
M Sources/PGMidi/PGArc.h (4)
M Sources/PGMidi/PGMidi.mm (2)

Patch Links
https://github.com/petegoodliffe/PGMidi/pull/6.patch
https://github.com/petegoodliffe/PGMidi/pull/6.diff

—
Reply to this email directly or view it on GitHub (https://github.com/petegoodliffe/PGMidi/pull/6).

—
Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub (https://github.com/petegoodliffe/PGMidi/pull/6#issuecomment-10604806).

tkemp commented 11 years ago

Very much appreciated, thank you!

Tim

On 21 Nov 2012, at 12:24, Pete Goodliffe wrote:

Hey, that looks awesome!

Nice work.

Pete Goodliffe, Principal Software Developer e. pete@goodliffe.net w. www.goodliffe.net s. petegoodliffe

On Wednesday, 21 November 2012 at 16:50, Tim Kemp wrote:

You're welcome. As you ask to be told when someone uses it, PGMidi is included in the latest release of my synth WOPR (www.omnivoresoft.com (http://www.omnivoresoft.com)).

On 21 Nov 2012, at 11:35, Pete Goodliffe wrote:

Many thanks!

Pete

Pete Goodliffe, Principal Software Developer e. pete@goodliffe.net w. www.goodliffe.net (http://www.goodliffe.net) s. petegoodliffe

On Wednesday, 21 November 2012 at 16:29, Tim Kemp wrote:

Hi Pete, Two changes: wrapped an @autorelease (https://github.com/autorelease) scope around the packet transfer code in PGArc.h and fixed a stuck boolean in the network session code. Thanks for this. Cheers, Tim You can merge this Pull Request by running: git pull https://github.com/tkemp/PGMidi master Or view, comment on, or merge it at: https://github.com/petegoodliffe/PGMidi/pull/6 Commit Summary Fixed memory leak when receiving packets. Fixed bug where MIDI network sessions were always enabled.

File Changes M Sources/PGMidi/PGArc.h (4) M Sources/PGMidi/PGMidi.mm (2)

Patch Links https://github.com/petegoodliffe/PGMidi/pull/6.patch https://github.com/petegoodliffe/PGMidi/pull/6.diff

— Reply to this email directly or view it on GitHub (https://github.com/petegoodliffe/PGMidi/pull/6).

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub (https://github.com/petegoodliffe/PGMidi/pull/6#issuecomment-10604806).

— Reply to this email directly or view it on GitHub.