search

petehamilton / citier

CITIER (Class Inheritance & Table Inheritance Embeddings for Rails) is a solution for simple Multiple Class Inheritance in Rails.
88 stars 24 forks source link

Fixed issues #9, #13, #26, #27, #28, #29, #30, and some more. #31

Closed DouweM closed 13 years ago

DouweM commented 13 years ago

913c3c0 is a fix to #28 81b2b17 is a fix to #29 4a7cc8c is a fix to #13 7c8f74a is a fix to #30 8b595a4 + 294d6a2 is a fix to #27 f6d8abd is a fix to #26 801b76e is mentioned here 51aa7dc + 6ddc33d + 2a61bbd is a fix to #9

Before the patch in d2894a2, changes that caused a child's value to be equal to the default value were not included in the UPDATE query, causing the database not to have to correct data. This fixes that by copying over the child's @changed_attributes, so that child::Writable knows what actually needs to be committed.

DouweM commented 13 years ago

In 8b595a4, I only checked whether the first tuple was of self's type, but of course I need to do this check for every tuple in the array because it could be the other tuples are not of self's type. This is fixed in 294d6a2.

axsuul commented 13 years ago

For database migrations, I'm getting undefined method create_view?

DouweM commented 13 years ago

Right. You'll need to add this to your Gemfile:

gem 'rails_sql_views', :git => 'git://github.com/morgz/rails_sql_views.git'

This commit by morgz has actually been here since July, so I thought by now everyone would have it ;-)

axsuul commented 13 years ago

Thanks wasn't aware of that dependency! That did the trick.

petehamilton commented 13 years ago

Brilliant work mate, keep it up, had to sideline this due to other commitments but will be back on it soon!