search

petejohanson / zaphod-config

41 stars 96 forks source link

How to change `CONFIG_ZMK_COMBO_MAX_KEYS_PER_COMBO` #1

Open YHRen opened 2 years ago

YHRen commented 2 years ago

Hi @petejohanson

Thank you for the repo. Really enjoy the keyboard. I think I'm hitting the limit of the default setting of CONFIG_ZMK_COMBO_MAX_KEYS_PER_COMBO=4. I tried to add CONFIG_ZMK_COMBO_MAX_KEYS_PER_COMBO=6 to zaphod_defconfig file, but it does not seem to work. Any advice on how to make such change?

Thank you so much!

petejohanson commented 2 years ago

Are you building locally or using GH Actions?

YHRen commented 2 years ago

Are you building locally or using GH Actions?

I'm currently using the GH Actions following your tutorials. I'm not so sure how to set up a local environment. The west environment is new to me.

merlinvn commented 2 years ago

Hi, is there any update on this? I currently experiment with combo with the following positions: (1,2), (2,3), (1,3) and (1,2,3) but so far the (1,2,3) combo doesn't work.

merlinvn commented 1 year ago

Solved it in the GH Adtions build by adding the following step. Other configs can be modified in the similar way.

     - name: List modules (west list)
        run: west list

      - name: update max combos per key
        run: ln="$(($(sed -n '/ZMK_COMBO_MAX_COMBOS_PER_KEY/=' zmk/app/Kconfig)+2))"; sed -i "${ln}s/default \([0-9]*\)/default 16/" zmk/app/Kconfig

      - name: Build Zaphod (west build)
        run: west build -s zmk/app -b zaphod -d build/zaphod -- -DZMK_CONFIG="${GITHUB_WORKSPACE}/config"