search

petems / riot_api

A Ruby wrapper for the Riot API for League of Legends - https://developer.riotgames.com/api/
MIT License
12 stars 3 forks source link

Implement new api version #44

Open pcg79 opened 10 years ago

pcg79 commented 10 years ago

Just in time for the holidays Riot releases new version of the end points:

http://developer.riotgames.com/discussion/riot-games-api/show/rXIx7RPr

game 1.2 league 2.2 stats 1.2 summoner 1.2 team 2.2

petems commented 10 years ago

Hmm, how about an attribute @version, default to 1, so we don't break backwards compatibility?

pcg79 commented 10 years ago

I like that. Only issue is if Riot doesn't update them all simultaneously in the future.

Right now I'd say it's all still new enough that we're ok just making the changes to what we have. But it does raise a good point for what to do in the future when it's all not so new.

If we decide to implement all versions of the API that Riot releases, we may potentially have a rather large codebase. We'd need to version not only the resources but the models and all the tests as well. Yeesh. Pros would include only having to support one gem.

If we decide to only support the newest API endpoints, we could make it clear which version of the API is supported by any given gem version. Down side to that is having to update multiple branches/gem versions with any fixes found. Altho we wouldn't be the first developers to say fixes will not be backported.

Easiest in the long run is definitely only to support the latest and greatest and not backport any fixes. Also the least end-user friendly. :-/

pcg79 commented 10 years ago

Hope you had a good holiday. You put anymore thought into how we want to do this?

IMHO, we just support the latest and greatest Riot API endpoints.

pcg79 commented 10 years ago

@petems If you aren't interested in support this anymore, any issues w/ me doing so? My fork would become the official repo. I'm not sure how the creation of the gem would work as I haven't published my own gem before but I assume there's a way to grant me rights to do so.

petems commented 10 years ago

Sorry, Ive been busy with work recently, I'll probably get a chance to have a go at this over the weekend.

petems commented 10 years ago

Ok, I've had a little looksie, I say we just jump to the newer version. If someone's using the gem and wants an earlier version number, then they can use and older release of the gem. Means the least backporting at least :+1:

pcg79 commented 10 years ago

Very cool. I'll probably end up working on it some tomorrow or this weekend.

Np about work. Just didn't know if you'd lost interest. No hard feelings either way. :)