search

petems / riot_api

A Ruby wrapper for the Riot API for League of Legends - https://developer.riotgames.com/api/
MIT License
12 stars 3 forks source link

Moved endpoint version out of base_url. #8

Closed pcg79 closed 10 years ago

pcg79 commented 10 years ago

Riot has different endpoint versions for different points. For example, champion is 1.1 but league is 2.1. This allows each module to implement their own endpoint version.

Unfortunately I should've implemented this before implementing the methods for game and champions as those will need to be modified slightly to add the version to their respective paths.

If you want to pull this in first, I'll fix my other two PRs to use the endpoint_version. Then I'll write the methods for league.

Tests are green locally w/ this branch.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling e11e30c61464529e04b9d35471b670fe3b94c348 on pcg79:move_version_out_of_base_path into f588ee654ec7d5650be90117858006a099a3292f on petems:master.