petems / tugboat

A command line tool for interacting with your DigitalOcean droplets.
MIT License
1.45k stars 89 forks source link

Enable pagination for Droplets list #210

Closed lachesis closed 8 years ago

lachesis commented 8 years ago

Fixes #205

lachesis commented 8 years ago

So, the tests are failing because I change the URL to always explicitly pass the page number. However, even once I fixed that, all of the fixtures are for a paginated account! I could fix that by modifying the fixtures, then I should probably write at least one test for the paginated case. That's a lot of work, though, and this works for my use case. I'll try to get back to cleaning it up, but no promises.

petems commented 8 years ago

Hi @lachesis! Perfect, thanks for this, was going to work on fixing this at the weekend, saved me the job :smile:

I've rebased to fix a bug and to add the new specs, and change the existing fixtures with the new stubs in light of these changes, see #212 for details.