search

peter-evans / create-or-update-comment

A GitHub action to create or update an issue or pull request comment
MIT License
706 stars 113 forks source link

Can't find the created `comment-id` #166

Closed awxiaoxian2020 closed 1 year ago

awxiaoxian2020 commented 1 year ago

https://github.com/reactjs/zh-hans.react.dev/actions/runs/4649911071/jobs/8228580063 in this job, it create comment id: issue1

but in newer action, with debug mode, we can see comment id is empty string. https://github.com/reactjs/zh-hans.react.dev/actions/runs/4649920633/jobs/8228646419 issue2

related to https://github.com/reactjs/zh-hans.react.dev/pull/1124. I will update the version to solve it and if it works fine, I will close this issue.

awxiaoxian2020 commented 1 year ago

still failed to find it see reactjs/zh-hans.react.dev#1125 and related action: https://github.com/reactjs/zh-hans.react.dev/actions/runs/4650014350 https://github.com/reactjs/zh-hans.react.dev/actions/runs/4650028981

peter-evans commented 1 year ago

Hi @awxiaoxian2020

Maybe I'm misunderstanding, but it looks like you are searching for <!-- __NEXTJS_BUNDLE --> here, but the comment body contains <!-- __NEXTJS_BUNDLE_react-dev --> here.

awxiaoxian2020 commented 1 year ago

You are right! Thanks very much indeed!