peter-evans / link-checker

A GitHub action for link checking repository Markdown and HTML files
MIT License
49 stars 11 forks source link

exclude doesn't appear to work #36

Closed booyaa closed 3 years ago

booyaa commented 3 years ago
      - name: Link Checker
        id: lc
        uses: peter-evans/link-checker@v1
        with:
          args: -r -x 'github|portal|windows' src/*

The exclusion regex 'github|portal|windows' doesn't work.

I've tested locally using liche v0.2.0 and the exclusions do work liche -r -x 'github|portal|windows' src/*

peter-evans commented 3 years ago

Hi @booyaa

Can you explain in what way it doesn't work. Does it throw an error? Does it ignore the exclusions?

Perhaps it's due to unescaped quotes. You could experiment with something like this:

        with:
          args: '-r -x "github|portal|windows" src/*'
booyaa commented 3 years ago

Apologies @peter-evans the exclusions were being ignored i.e. links containing those terms were still being checked. I'll give the quotes a go, thanks!

booyaa commented 3 years ago

Quotes fixed the issue, thanks @peter-evans ! 🎉