peter-frentrup / NppMenuSearch

Notepad++ Menu Search Plugin
Other
39 stars 11 forks source link

Access Violation as of Notepad++ commit 84c1505 #28

Closed vinsworldcom closed 2 years ago

vinsworldcom commented 2 years ago

@peter-frentrup

As of Notepad++ commit 84c1505, the plugin crashes with Access Violation error (it doesn't even load).

Using Windows 10 64-bit with Notepad++ (commit referenced above), 64-bit.

peter-frentrup commented 2 years ago

Hello, thank you for your report. The mentioned commit 84c1505 has a malformed english.xml: && should be written as &&. Would fixing that help? (I cannot reproduce the crash here).

Best regards, Peter

vinsworldcom commented 2 years ago

@peter-frentrup - thank you so much for responding and continuing to support this excellent plugin. I never search Notepad++ menus for operations I want, I just call this plugin and type some related word and find the function I want. I use it during every Notepad++ editing session.

I tied fixing the english.xml manually - didn't seem to work. So I got a fresh copy of Notepad++ 8.1.4 and unzipped to a local directory. I upgraded the notepad++.exe only to the c1cce29 commit here which fixes that error (according to the commit message. I added the NppMenuSearch plugin and still get the access violation.

I should note I'm using my existing copy of NppMenuSearch - 0.9.3.43074

image

Cheers.

peter-frentrup commented 2 years ago

Dear @vinsworldcom, I was able to reproduce the issue. The root cause is that Notepad++ commit 84c1505 added two static controls with the same control identifier IDC_STATIC to the preferences dialog PowerEditor/src/WinControls/Preference/preference.rc. I am currently implementing a workaround.

Cheers, Peter

vinsworldcom commented 2 years ago

Notepad++ commit 84c1505 added two static controls with the same control identifier IDC_STATIC to the preferences dialog PowerEditor/src/WinControls/Preference/preference.rc

Is that lines 395, 396?

peter-frentrup commented 2 years ago

Yes, those two lines.

The issue should be fixed with version 0.9.5

vinsworldcom commented 2 years ago

The issue should be fixed with version 0.9.5

INDEED - it is! Just tested. THANK YOU for the quick response and continued support of this excellent plugin.

Cheers.