search

peter-frentrup / NppMenuSearch

Notepad++ Menu Search Plugin
Other
40 stars 11 forks source link

Change to dotnet 4.8 and use PackageReference instead of packages.config #39

Open alireza-delavari opened 1 year ago

alireza-delavari commented 1 year ago

I used "UnmanagedExports.Repack.Upgrade" package instead of "UnmanagedExports".
if build failed, remove bin and obj folders.

peter-frentrup commented 1 year ago

Hello, thank you for your time an effort. However, I am reluctant to the proposed change of the target framework: Why is a change to .Net Framework 4.8 necessary? What is the benefit for the user? 4.0 should be compatible with 4.8, so the plugin should be able to run on a PC with only 4.8 installed.

Your fix for x64 is worth looking into. But that class "ClikeStringArray" does not seem to be used at all. So maybe I should just delete it...

Best regards, Peter

alireza-delavari commented 1 year ago

Hello and thank you for your time. I am using visual studio 2022 and when I opened this project, it suggest to upgrade to .Net Framework 4.8 . I tried installing .Net Framework 4.0 but accoring to the note at end of this page , we can't load .Net Framework 4.0 projects to newer versions of Visual Studio.

I used "ClikeStringArray" class in this #40 pull request, I also applied that x64 fix to that pull request again so this two pull requests doesn't have dependency with each other.

peter-frentrup commented 1 year ago

That's a shame. The link you mention suggests that the problem is due to your other change to "UnmanagedExports.Repack.Upgrade" instead of "UnmanagedExports". Staying with "UnmanagedExports" allows to keep "packages.config".

Gitoffthelawn commented 10 months ago

I agree that .Net Framework 4.8 is undesirable unless truly needed. There are many offline systems that use Notepad++ that do not have .Net Framework 4.8 installed.