Closed JozsefBartokHFT closed 10 years ago
JozsefBartokHFT
commented
10 years ago Pls. ignore anything I've said about the broken test. It's very likely caused by the changes I've made to hashing, the fact that I've broken thread safety. I'll fix it, it was just tiredness making me lazy.
Pls. just take a quick look if the general style of the solution is acceptable and ok to be extended to SHM.
peter-lawrey
commented
10 years ago Ok. Will look at this in abput 5 hrs when I wake up ;) On 10 Mar 2014 02:38, "JozsefBartokHFT" notifications@github.com wrote:
Pls. ignore anything I've said about the broken test. It's very likely caused by the changes I've made to hashing, the fact that I've broken thread safety. I'll fix it, it was just tiredness making me lazy.
Pls. just take a quick look if the general style of the solution is acceptable and ok to be extended to SHM.
Reply to this email directly or view it on GitHubhttps://github.com/OpenHFT/HugeCollections/pull/15#issuecomment-37129767 .
Working and 99% complete entrySet(), keySet() and values() methods for HugeHashMap. I'm missing some functionality for values() (remove to be reflected in the map), but the rest should be there. Pls. take a look, let me know if it's ok if I go the same way for SHM too, or you would prefer some other approach.
Also found a bug, where size was not properly reset on map.clear().
Also managed to BREAK HugeHashMapTest.testPutPerf(), I don't yet know why... Pls. comment if it's obvious to you, otherwise I'll investigate further. Btw. how do you normally run all the unit tests? From IntelliJ?