search

peter-lawrey / Java-Chronicle

Java Indexed Record Chronicle
1.22k stars 193 forks source link

readUnsignedShort return undignedbyte #13

Closed JijunWang closed 11 years ago

JijunWang commented 12 years ago

In the #readUnsignedShort methods, we should use "readShort() & 0xFFFF" rather than "readShort() & 0xFF". I guess it's a typo. And sounds like

@Override public void writeUnsignedShort(int offset, int v) { writeUnsignedShort(offset, v); }

should be @Override public void writeUnsignedShort(int offset, int v) { writeShort(offset, v); }

BTW, thanks for this great library.

peter-lawrey commented 12 years ago

You are right in both cases. Would you like to try pushing these changes?

JijunWang commented 12 years ago

I can, but i'm not family with GitHub. I need to figure out how to do it just for changing couple lines. If you don't mind i can do it, and i may need your guides. On Aug 30, 2012 5:07 PM, "Peter Lawrey" notifications@github.com wrote:

You are right in both cases. Would you like to try pushing these changes?

— Reply to this email directly or view it on GitHubhttps://github.com/peter-lawrey/Java-Chronicle/issues/13#issuecomment-8174546.

peter-lawrey commented 12 years ago

This web site has surprisingly good documentation. It a bit of a pain to setup compared with subversion but once you have it works very well.

peter-lawrey commented 11 years ago

That appears to be fixed now.