peter-lawrey / Java-Chronicle

Java Indexed Record Chronicle
1.22k stars 193 forks source link

Make Java Chronicle OSGi ready #35

Closed lburgazzoli closed 8 years ago

lburgazzoli commented 11 years ago

Would it be possible to build Java Chronicle as OSGi bundle?

peter-lawrey commented 11 years ago

It was an OSGi bundle, it appears that a refactor done earlier broke this. I will try to fix this this week.

On 27 August 2013 21:23, lburgazzoli notifications@github.com wrote:

Would it be possible to build Java Chronicle as OSGi bundle?

— Reply to this email directly or view it on GitHubhttps://github.com/peter-lawrey/Java-Chronicle/issues/35 .

lburgazzoli commented 10 years ago

I did check the version 1.8 and now it is OSGi compliant but it does not export the package com.higherfrequencytrading.chronicle.impl which is required by other bundles (example reactor https://github.com/reactor/reactor):

[ 197] [Installed  ] [            ] [   80] chronicle (1.8.0)
karaf@lb> export 197
Command not found: export
karaf@lb> exports 197
    ID Packages                                
   197 com.higherfrequencytrading.chronicle; version=1.8.0
   197 com.higherfrequencytrading.chronicle.datamodel; version=1.8.0
   197 com.higherfrequencytrading.chronicle.math; version=1.8.0
   197 com.higherfrequencytrading.chronicle.tcp; version=1.8.0
   197 com.higherfrequencytrading.chronicle.tcp.gw; version=1.8.0
   197 com.higherfrequencytrading.chronicle.tools; version=1.8.0

Is that intentional?

peter-lawrey commented 10 years ago

I have checked that the impl package is in the MANIFEST file now. I have released 1.8.1

On 26 September 2013 05:30, lburgazzoli notifications@github.com wrote:

I did check the version 1.8 and now it is OSGi compliant but it does not export the package com.higherfrequencytrading.chronicle.impl which is required by other bundles (example reactor https://github.com/reactor/reactor):

[ 197] [Installed ] [ ] [ 80] chronicle (1.8.0) karaf@lb> export 197 Command not found: export karaf@lb> exports 197 ID Packages 197 com.higherfrequencytrading.chronicle; version=1.8.0 197 com.higherfrequencytrading.chronicle.datamodel; version=1.8.0 197 com.higherfrequencytrading.chronicle.math; version=1.8.0 197 com.higherfrequencytrading.chronicle.tcp; version=1.8.0 197 com.higherfrequencytrading.chronicle.tcp.gw; version=1.8.0 197 com.higherfrequencytrading.chronicle.tools; version=1.8.0

Is that intentional?

— Reply to this email directly or view it on GitHubhttps://github.com/peter-lawrey/Java-Chronicle/issues/35#issuecomment-25163519 .

peter-lawrey commented 10 years ago

BTW You might find that Chronicle 2.0.1 is faster than 1.8.1. ;)

https://github.com/OpenHFT/Java-Chronicle

On 26 September 2013 06:30, Peter Lawrey peter.lawrey@gmail.com wrote:

I have checked that the impl package is in the MANIFEST file now. I have released 1.8.1

On 26 September 2013 05:30, lburgazzoli notifications@github.com wrote:

I did check the version 1.8 and now it is OSGi compliant but it does not export the package com.higherfrequencytrading.chronicle.impl which is required by other bundles (example reactor https://github.com/reactor/reactor):

[ 197] [Installed ] [ ] [ 80] chronicle (1.8.0) karaf@lb> export 197 Command not found: export karaf@lb> exports 197 ID Packages 197 com.higherfrequencytrading.chronicle; version=1.8.0 197 com.higherfrequencytrading.chronicle.datamodel; version=1.8.0 197 com.higherfrequencytrading.chronicle.math; version=1.8.0 197 com.higherfrequencytrading.chronicle.tcp; version=1.8.0 197 com.higherfrequencytrading.chronicle.tcp.gw; version=1.8.0 197 com.higherfrequencytrading.chronicle.tools; version=1.8.0

Is that intentional?

— Reply to this email directly or view it on GitHubhttps://github.com/peter-lawrey/Java-Chronicle/issues/35#issuecomment-25163519 .

lburgazzoli commented 10 years ago

thx, I'll check it out. btw I see that you have also started working on a FIX engine, interesting

peter-lawrey commented 10 years ago

My next task is file rotation support in Chronicle 2.1

On 26 September 2013 06:49, lburgazzoli notifications@github.com wrote:

thx, I'll check it out. btw I see that you have also started working on a FIX engine, interesting

— Reply to this email directly or view it on GitHubhttps://github.com/peter-lawrey/Java-Chronicle/issues/35#issuecomment-25168614 .