search

peter-lawrey / Java-Chronicle

Java Indexed Record Chronicle
1.22k stars 193 forks source link

about createIndexBuffer method in IndexedChronicle class #38

Open taigetco opened 10 years ago

taigetco commented 10 years ago

I have checked FileChannelImpl.java, the map method has already checked the OutOfMemoryError exception, done the full gc, so should remove the same behavior code in createIndexBuffer method?

peter-lawrey commented 10 years ago

Good question. I will investigate. On 27 Dec 2013 09:10, "matthewtt" notifications@github.com wrote:

I have checked FileChannelImpl.java, the map method has already checked the OutOfMemoryError exception, done the full gc, so should remove the same behavior code in createIndexBuffer method?

— Reply to this email directly or view it on GitHubhttps://github.com/peter-lawrey/Java-Chronicle/issues/38 .