search

peter-lawrey / TransFIX

Faster FIX engine.
http://chronicle.software/products/transfix/
GNU Lesser General Public License v3.0
87 stars 49 forks source link

JDK8 compatibility #17

Closed derjust closed 9 years ago

derjust commented 9 years ago

Hi!

Building the library with JDK8 fails as javadoc is more strict. Therefore fixed that. Also the test method must be public.

Organized also some imports, moved main-methods to be Test.

Any chance that this library becomes available on one of the public repositories?

RobAustin commented 9 years ago

Thanks for your enhancements. Yes, we are planning to release it soon. We were planning to apply some minor refactors first, but these can always be done in the next version.

I'll speak with the rest of the team, with a view to releasing ( what's there ) in the next few days.

Rob

On 21 Mar 2015, at 03:21, Sebastian J. notifications@github.com wrote:

Hi!

Building the library with JDK8 fails as javadoc is more strict. Therefore fixed that. Also the test method must be public.

Organized also some imports, moved main-methods to be Test.

Any chance that this library becomes available on one of the public repositories?

You can view, comment on, or merge this pull request online at:

https://github.com/OpenHFT/TransFIX/pull/17

Commit Summary

Fields are 1-based Ignoring Eclipse-specific files Make it compile with JDK8 - javadoc is more strict Translated main(String...) methods to testcases Organize imports Close buffer properly File Changes

M .gitignore (6) M src/main/java/net/openhft/fix/include/util/FixConfig.java (6) M src/main/java/net/openhft/fix/include/util/FixConstants.java (10) M src/main/java/net/openhft/fix/include/v42/FIXMessageBuilder.java (22) M src/main/java/net/openhft/fix/include/v42/FixFieldInterface.java (2) M src/main/java/net/openhft/fix/include/v42/FixMessageReader.java (75) A src/test/java/net/openhft/fix/include/util/FixConstantsTest.java (15) A src/test/java/net/openhft/fix/include/v42/FIXMessageBuilderTest.java (30) A src/test/java/net/openhft/fix/include/v42/FixMessageReaderTest.java (56) M src/test/java/net/openhft/fix/include/v42/examples/TestTransFix.java (12) Patch Links:

https://github.com/OpenHFT/TransFIX/pull/17.patch https://github.com/OpenHFT/TransFIX/pull/17.diff — Reply to this email directly or view it on GitHub.