Delay/Slowness when navigating

khumphrey-sb commented 6 years ago

Steps to reproduce

Implement react-navigation-is-focused-hoc
use decorator @withNavigationFocus('MyControl')
slowness/delay when navigating

Expected behaviour

Navigation should occur without delay.

Actual behaviour

There is a very noticeable delay between when the press happens and when the navigation action starts.

Environment

React Navigation version: "react-navigation": "^1.0.0-beta.22",
Node.js version: v8.9.1
React Native version: "react-native": "0.51.0",
React Native platform + platform version: iOS 9.0, Android 5.0, etc

iOS simulator 11.2, Android Pixel 2 simulator, iPhone 6 physical device running 11.2

react-navigation-is-focused-hoc

Version: "react-navigation-is-focused-hoc": "^1.1.1"

Commenting out updateFocus(currentState) in the onNavigationStateChange makes the delay go away.

I've currently only decorated two of my screen controls in a large existing app with HOC for testing. The events are working fine, but the delay after the press makes it a non starter. I can try to replicate using a smaller app but was wondering if anyone had seen this before.

mikeduminy commented 6 years ago

I'm also experiencing this problem.

anasvemmully commented 6 months ago

+1

peter-mach / react-navigation-is-focused-hoc