search

peter-mouland / react-lego

React-lego : incrementally add more cool stuff to your react app
http://react-lego.herokuapp.com/
MIT License
414 stars 36 forks source link

Remove react hot reload? #11

Closed dlebedynskyi closed 7 years ago

dlebedynskyi commented 7 years ago

See https://github.com/gaearon/react-hot-boilerplate/issues/97#issuecomment-249862775

it looks like react hot reloader is dead. In a good way. Btw really great project 👍

peter-mouland commented 7 years ago

hmmm, interesting discussion, I can see the reason for his pivot! thanks for pointing out the link.

I'll have to let this sleep on it and also see how the community Reacts.

dlebedynskyi commented 7 years ago

@peter-mouland yap. just giving heads up. I did picked up a lot from this repo myself It looks like a lot of work he plans to cover in create react app.

What is missing is server stuff since apparently not going to happen https://github.com/facebookincubator/create-react-app/pull/500#issuecomment-242764176

Imho I'd really love to see create-react-app + universal part.

peter-mouland commented 7 years ago

yeah, I'm sure they'll get round to it, sounds like stability is key t start with which is fair.

There seems to be a few great boiler-plates/helpers out there that are missing that sometimes essential ingredient of being universal. when i have the time i'll take start of this app back one level and do a branch to show client-side react vs universal react.

ngoctranfire commented 7 years ago

I would like to say that one of the things that we forget is that most of the time, react-hot-loader is not a standalone that is used by itself. With stores/redux in mind, this makes hot-reloading a little bit trickier. I think having an example that branches off from the redux branch will make it more friendly, and maybe one that is branched off the react-router-4 as well? There are so many moving parts at any time.

peter-mouland commented 7 years ago

Thanks for the discussion guys. I'm going to leave it in at least until React comes with it baked in.

The other branches makes sense as suggestions so i've raised issues for those (PR's welcome!) Hopefully it'll be as easy as the webpack2-rhl branch which just worked!