search

peter-mouland / react-lego

React-lego : incrementally add more cool stuff to your react app
http://react-lego.herokuapp.com/
MIT License
414 stars 36 forks source link

On Branch css-modules, webpack build:server command fails #19

Closed ngoctranfire closed 8 years ago

ngoctranfire commented 8 years ago

Hi, I noticed that when I tried to run npm run build:server on the css-modules branch, it breaks and that does not allow me to do a good npm run start. I think that the reason this is happening is related to this issue with https://github.com/css-modules/css-modules-require-hook/issues/67. I'm working on trying to see if I can fix it, but maybe someone who knows this stuff better may be able to give me a helping hand on this.

peter-mouland commented 8 years ago

good spot, not sure when that crept in. It looks like a mix up in css-modules-require-hook dependencies or they are accidentally run tests after we install the package.

I've raised an issue with them also: https://github.com/css-modules/css-modules-require-hook/issues/79

ngoctranfire commented 8 years ago

This error also appears on the svg branch as well I believe it is the same type of error.

peter-mouland commented 8 years ago

I've fixed the css-modules branch by bumping the version number and by stop using the preset option