search

peter-mouland / react-lego

React-lego : incrementally add more cool stuff to your react app
http://react-lego.herokuapp.com/
MIT License
414 stars 36 forks source link

Hot-reload branch does not work as expected #24

Closed ngoctranfire closed 8 years ago

ngoctranfire commented 8 years ago

Sorry to be filing so many bugs and such, but I really like your project and its actually helped me to learn redux by the pieces and get to understand the numerous moving parts that are so confusing to me. On your react-hot-loader branch, just by itself, I noticed that it just doesn't work correctly. When I make a change, the changes are not updated automatically. Also, I was getting this error at the beginning: not sure if it's related.

HMR] Update check failed: Error: Manifest request to /6a46934f57636f62dc58.hot-update.json timed out. at XMLHttpRequest.request.onreadystatechange (http://localhost:3000/app.js:34:23)

peter-mouland commented 8 years ago

keep them coming :) I have noticed things go wrong after seemingly simple rebase from master - i should i guess write a specific e2e test to prove each branches purpose to stop that from happening.

I haven't seen the problem you mention, but i'll take a look and try to replicate it.

peter-mouland commented 8 years ago

out

This is hot-reloading working for me... granted I get a different error!

dlebedynskyi commented 8 years ago

granted I get a different error!

this is known issue with hot reloading and react router v2.

peter-mouland commented 8 years ago

yeah, i'm tempted to ignore it in the hope the the final RHL v3 and the final RR v4 aren't far away!

in the mean-time 🙉 🙈

peter-mouland commented 8 years ago

I haven't seen this bug still so will close the branch.. if you can show me how to replicate it in reat-lego, then we can reopen