search

peter-murray / node-hue-api

Node.js Library for interacting with the Philips Hue Bridge and Lights
Apache License 2.0
1.18k stars 145 forks source link

Fix ts types #184

Closed Roaders closed 3 years ago

Roaders commented 3 years ago

There are quite a few type definitions that are incomplete or just any. Would you accept Pull Requests to fix this?

peter-murray commented 3 years ago

Hi, I am currently doing a lot of refactoring around the definitions and generation of these moving forward.

I have extracted the model into a pure TypeScript library https://github.com/peter-murray/hue-bridge-model that is now being pulled into the main branch which will be used to perform a 4.x version release before I cut a 5.x version release later this month.

I am happy to accept PRs, but due to the refactoring work, they might already be handled or on my list to sort out. Are you happy to share any areas you have problems with any types and I can take a look to ensure these are covered and resolved?

Roaders commented 3 years ago

Ok, that sounds great. Thanks.