peter-murray / node-hue-api

Node.js Library for interacting with the Philips Hue Bridge and Lights
Apache License 2.0
1.18k stars 144 forks source link

ApiError: Problems resolving hue bridges, HTTP error status: 429 #222

Closed lexicalunit closed 2 years ago

lexicalunit commented 2 years ago

I have a CLI built using node-hue-api that has been working fine for months. Suddenly I'm getting rate limits now. I got a rate limit today and I haven't even run the CLI once today before that. The rate limits make no sense.

    at /opt/myapp/node_modules/node-hue-api/dist/cjs/api/discovery/nupnp.js:15:15
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (/opt/myapp/cli.js:44:21) {
  _hueError: undefine
pixlpirate commented 2 years ago

Same for me, identical error status and message. My script has been working fine for months until today.

peter-murray commented 2 years ago

It is not the library; https://developers.meethue.com/rate-limiting-status-code/

peter-murray commented 2 years ago

I have a complete lack of visibility to the use case here and the full manifestation of the error, can you provide some more context and a reproducible way for this error to be created?

lexicalunit commented 2 years ago

This is the code: https://github.com/lexicalunit/busylight/blob/main/cli.js

Essentially I'm just doing:

    const results = await discovery.nupnpSearch()
    const host = results[0].ipaddress
    const secure = await api.createLocal(host).connect(settings.username)
    const light = (await secure.lights.getLightByName(options.light))[0]
    const state = stateFromOptions(options)
    await secure.lights.setLightState(light.id, state)
pindab0ter commented 2 years ago

I'm experiencing the same issue when trying to develop an extension using this package. When I started today, everything was alright. But after several uses of discovery.nupnpSearch() I'm now getting the exact same issue.

For the record, all I've used for this error to appear up until this point is discovery.nupnpSearch().

peter-murray commented 2 years ago

From the Hue documentation it looks to be active as of now:

NOTE 1 – UPnP (or more specifically the UPnP subset Simple Service Discovery Protocol (SSDP)) used to be available as another discovery method but has been deprecated in favor of mDNS and will be disabled in Q2 2022.

peter-murray commented 2 years ago

That deprecation warning should no impact this particular endpoint, as the nupnp search is reaching out to the Hue cloud to get the data back for the known register bridges, https://discovery.meethue.com

They will have some level of rate limiting on this endpoint to stop abuse, but I cannot see any details on a rate limit documented anywhere. Do you know how many calls you are making before this starts to trigger?

peter-murray commented 2 years ago

I managed to reproduce the rate limiting by hitting just the end point around 10 times in less than a minute. Hue are clearly protecting this endpoint now more than they used to, and it is technically an unauthenticated endpoint, so is a reasonable safety measure I guess to stop abuse...

That said, nothing that I am going to be able to remedy here, it is enforced by Hue themselves, I will take a look into the headers to see if there is any extra data about the rate limits, but nothing that I can change from the library side, Hue own the endpoint and can do whatever they like here.

pindab0ter commented 2 years ago

I just did a quick test and the limit seems to be 12. The thirteenth request fails. I don't know what the timeframe is.

peter-murray commented 2 years ago

Nothing useful in the returned headers indicating a window, number of api calls remaining or reset time: Screenshot 2022-08-01 at 12 21 40

peter-murray commented 2 years ago

I found this snippet buried in the Hue docs

The rate limit of using the discovery endpoint is maximum one request per 15 minutes per client. Typically it should be much less than that because the discovered IP can be stored and only rechecked when a request times out (as the ip might have changed). More regular ip scanning can always be done with mDNS.

peter-murray commented 2 years ago

With the deprecation of the UPnP and the addition of mDNS, it looks like I will need to add that to the library as an alternative approach for discovery now.

peter-murray commented 2 years ago

I have released a new version with mDNS support, see here for details https://github.com/peter-murray/node-hue-api/issues/221#issuecomment-1214181471

pindab0ter commented 2 years ago

Works great on my end! Discovery takes about 4s for me, every time. So maybe the default timeout could be a little more than 5s.

lexicalunit commented 2 years ago

Works great for me too!