search

peter-murray / node-hue-api

Node.js Library for interacting with the Philips Hue Bridge and Lights
Apache License 2.0
1.19k stars 145 forks source link

transistiontime should be transitiontime #6

Closed SamDecrock closed 11 years ago

SamDecrock commented 11 years ago

Hi,

We noticed that the transitiontime did not work. You misspelled it in hue-api/commands/traits/tLightStateBody.js

I also wondered why you don't just pass the json directly to the Hue Bridge?

peter-murray commented 11 years ago

Thanks for finding that, I have corrected it and will release it later tonight.

I use these traits as the data is used in a couple of the api end points. I wanted to capture the complete API definition that Phillips publish, so that it is easier to identify the changes when Phillips make modifications.

These values are also able to be used in creating schedules, and when I was adding schedule support to the API, I had some difficulty with getting the schedule command wrong at first. These traits and the extra data that is present in them is planned to be used to help perform some validation checking when setting up a schedule, as the bridge itself does none when it accepts the schedule.

SamDecrock commented 11 years ago

ok, I get it. Thanks for the answer. We used your module at Hacked.io last weekend ;-)

SamDecrock commented 11 years ago

Have you updated it on npm?

peter-murray commented 11 years ago

Sorry, had a family matter to deal with. Will promise to release it tonight.

peter-murray commented 11 years ago

It is released to npm now as version 0.2.1, sorry for the delay

SamDecrock commented 11 years ago

Awesome, thx!

Op 23 Jul 2013 om 22:20 heeft Peter Murray notifications@github.com het volgende geschreven:

It is released to npm now as version 0.2.1, sorry for the delay

— Reply to this email directly or view it on GitHub.