search

peter1591 / hearthstone-ai

A Hearthstone AI based on Monte Carlo tree search and neural nets written in modern C++.
302 stars 49 forks source link

Class card redeclares typename Card in common.h #25

Closed zappybiby closed 7 years ago

zappybiby commented 7 years ago

Two lines affected in common.h:

  1. https://github.com/peter1591/hearthstone-ai/blob/master/pilot_run/include/game-engine/cards/common.h#L118 which redeclares https://github.com/peter1591/hearthstone-ai/blob/master/pilot_run/include/game-engine/cards/common.h#L112 and

  2. https://github.com/peter1591/hearthstone-ai/blob/master/pilot_run/include/game-engine/cards/common.h#L161 which redeclares https://github.com/peter1591/hearthstone-ai/blob/master/pilot_run/include/game-engine/cards/common.h#L155

peter1591 commented 7 years ago

Yup, we should change the name. Feel free to change it and fire a pull request.

peter1591 commented 7 years ago

archive pilot run issues