search

peter279k / fork-CalendR

The missing PHP 7.3+ calendar management library.
http:/yohan.giarel.li/CalendR
MIT License
3 stars 4 forks source link

Ensure compatibility with Twig 3 #14

Closed relthyg closed 3 months ago

relthyg commented 4 months ago

The classes \Twig_Extension and \Twig_SimpleFunction have been removed in Twig 3 in favor of Twig\Extension\AbstractExtension and Twig\TwigFunction respectively. As these classes were only introduced in Twig 2.4.0, we have to drop support for older Twig versions here.

Silex support is dropped because the CalendRServiceProviderTest fails now without the \Twig_Extension class. As Silex is not maintained anymore, it should not be a problem to drop it's support. This should be considered as a BC-break.

peter279k commented 4 months ago

Due to the BC-break, I think we consider releasing the 3.2.0 version.

What do you think about that?

relthyg commented 4 months ago

According to SemVer, this would be a 4.0.0.

In SemVer x.y.z means

relthyg commented 3 months ago

Is anything still unclear here that I could help with?

peter279k commented 3 months ago

I've merged this PR and prepare to release the 4.0.0 version.

relthyg commented 3 months ago

Great, thank you

relthyg commented 1 month ago

Hey, it's been a while. Are you still planning to release version 4.0.0? Can I help with something?

peter279k commented 1 month ago

The 4.0.0 is released and sorry for my delay response.

https://github.com/peter279k/fork-CalendR/releases/tag/4.0.0

relthyg commented 1 month ago

Thank you!