New --index-url option is broken

peterbe / hashin

Helping you write hashed entries for packages in your requirements.txt

https://www.peterbe.com/plog/hashin

MIT License

106 stars 28 forks source link

Closed peterbe closed 5 years ago

peterbe commented 5 years ago

Fixes #108

CC @nmacinnis

peterbe commented 5 years ago

This is what happened:

def foo(index_url="SOME_DEFAULT"):
    print(repr(index_url))

foo(index_url=None)

The output of that becomes:

None

peterbe commented 5 years ago

@nmacinnis I'm confident this PR fixes the problem and so I'm going to go ahead and land it. Again, sorry I didn't test this manually enough.

nmacinnis commented 5 years ago

Ack, shame on me! Thanks for catching it and fixing!