peterbe / hashin

Helping you write hashed entries for packages in your requirements.txt
https://www.peterbe.com/plog/hashin
MIT License
106 stars 28 forks source link

Correct writing of hyphenated and underscored package names #117

Closed caphrim007 closed 4 years ago

caphrim007 commented 4 years ago

This patch changes hashin such that,

If the package specified has underscores in its name, but the new package has hyphens, the following occurs

Prior to this patch, the 1st case about would not occur. Instead, hashin would append the new version in its hyphenated form to the requirements file and leave the old version in its underscored form in the requirements file.

caphrim007 commented 4 years ago

@peterbe ready for review

caphrim007 commented 4 years ago

Fixes #116

caphrim007 commented 4 years ago

@peterbe I will send updates shortly. thanks for reviewing!

caphrim007 commented 4 years ago

changes made. Ready for review

peterbe commented 4 years ago

Travis isn't reporting checks here on the PR, but: https://travis-ci.org/github/peterbe/hashin/builds/698623654 is all green!