Doc: add nth-child in the list of pseudo classes for option --exclude-pseudoclasses - Githubissues

peterbe / premailer

Turns CSS blocks into style attributes

https://premailer.io

BSD 3-Clause "New" or "Revised" License

1.06k stars 188 forks source link

Doc: add nth-child in the list of pseudo classes for option --exclude-pseudoclasses #222

Open calixteman opened 5 years ago

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling c59e71d9bf2db14a4430798e62e48eccb8769734 on calixteman:issue_220 into d2d73c93a545b9c6a2ecd62f6cdba4539d6cb071 on peterbe:master.

peterbe commented 5 years ago

Seems @coveralls is broken. "Coverage remained the same at ?% when "

calixteman commented 5 years ago

So finally, only the doc changed to avoid to break something. So we'll have at least something to grep.

peterbe commented 5 years ago

You know what sucks? With argparse there is no way to NOT exclude pseudoclasses. All the boolean'y options in argparse needs to be False by default.

calixteman commented 5 years ago

Or we could store_false instead but that means that we must rename the option and so... break something, somewhere

peterbe commented 5 years ago

Wait! What am I saying! If you use python -m premailer then you get exclude_pseudoclasses False but if you use premailer.transform(html) you get exclude_pseudoclasses True. Sigh.

peterbe commented 5 years ago

oops.

peterbe commented 5 years ago

For now, can you just make that one last extra edit to the README (about :nth-child) and then we'll worry about differences in __main__ vs. programmatically later. Also, can you rebase to edit the commit message.