peterblattmann
commented
6 years ago Dear Ashton,
Sorry about my very late reply and I’m not sure if you already got a reply by me (I just found my original reply in my draft folder but it was not sent)?
Thank you very much for your e-mail and I will have a look in the next weeks on what you did and integrate all the changes I think make sense, if this is fine with you? It is great that you spend so much time on this!
Best regards
Peter
From: Ashton Trey Belew notifications@github.com Sent: Wednesday, June 13, 2018 11:32 PM To: peterblattmann/SWATH2stats SWATH2stats@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [peterblattmann/SWATH2stats] a case-insensitive fork (#1)
Greetings, I recently found that for whatever new version of openms/pyprophet/tric, one or more of the columns in my tsv input to SWATH2stats changed the capitalization of some column names.
In response, I decided to modify SWATH2stats rather than my input file and so I forked the code and merrily hacked away. I have not changed anything substantive (I think); but made all the columns case-insensitive via tolower(), and therefore all the places which query the columns. As I was doing this, I gradually filled in some roxygen docstrings. Only today I realized I should probably have written and asked before messing with your codebase; so I am writing now, though belatedly.
The changes I made are in the abelew/SWATH2stats repository; I just committed the docstring changes. If the modifications I made are not too obnoxious, I would be happy to rebase to your current state and send a pull request.
I hope you are doing well.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/peterblattmann/SWATH2stats/issues/1 , or mute the thread https://github.com/notifications/unsubscribe-auth/APESdjVmFVT5U17ZxfFnQs8o8M1njtk6ks5t8YTpgaJpZM4Um-B6 . https://github.com/notifications/beacon/APESdgKIrxMAAOKZjIvCvEoX4vzhrdTVks5t8YTpgaJpZM4Um-B6.gif
Greetings, I recently found that for whatever new version of openms/pyprophet/tric, one or more of the columns in my tsv input to SWATH2stats changed the capitalization of some column names.
In response, I decided to modify SWATH2stats rather than my input file and so I forked the code and merrily hacked away. I have not changed anything substantive (I think); but made all the columns case-insensitive via tolower(), and therefore all the places which query the columns. As I was doing this, I gradually filled in some roxygen docstrings. Only today I realized I should probably have written and asked before messing with your codebase; so I am writing now, though belatedly.
The changes I made are in the abelew/SWATH2stats repository; I just committed the docstring changes. If the modifications I made are not too obnoxious, I would be happy to rebase to your current state and send a pull request.
I hope you are doing well.