search

peterblattmann / SWATH2stats

https://peterblattmann.github.io/SWATH2stats/
1 stars 1 forks source link

first in a set of modifications. Invoked formatr::tidy_dir(). #3

Closed abelew closed 4 years ago

abelew commented 5 years ago

Thus the only changes in this diff are to standardize the spacing of each file according to the guidelines from Yihui Xie.

The next changes, in order and one pull request each:

  1. Add back roxygen2 docstrings.
  2. Standardize NSE R semantics.
  3. Case insensitivity.
  4. Minor plot changes.
  5. Additional options to sample_annotation() for flexibility.
  6. Recheck the test/ tree.
  7. Recheck the vignettes/ tree.
abelew commented 5 years ago

The second PR is the result of invoking dos2unix on every file in the repository.

abelew commented 5 years ago

ah, so close and comment means close the PR. I knew that! (Obviously I did not because I am very smrt.)

peterblattmann commented 4 years ago

Thanks again @abelew for the contribution! The move to roxygen has been commit in v1.19.1 (https://github.com/peterblattmann/SWATH2stats/commit/56f56c8a0e5e6fce52e8fafaeb2ce3eeff97a9c2)