search

peterbraden / node-opencv

OpenCV Bindings for node.js
MIT License
4.38k stars 857 forks source link

Resize (async) exception checking and memory leak prevention #583

Closed btsimonh closed 6 years ago

btsimonh commented 6 years ago

Eliminates a possible memory leak if an error occurs. Add try/catch to report errors via callback rather than blow node.

codecov-io commented 6 years ago

Codecov Report

Merging #583 into master will increase coverage by 0.02%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage    55.3%   55.32%   +0.02%     
==========================================
  Files          33       33              
  Lines        3884     3888       +4     
  Branches       30       30              
==========================================
+ Hits         2148     2151       +3     
- Misses       1736     1737       +1
Impacted Files Coverage Δ
src/Matrix.cc 55.19% <90%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdd0c97...6393a7f. Read the comment docs.