search

peterbrittain / asciimatics

A cross platform package to do curses-like operations, plus higher level APIs and widgets to create text UIs and ASCII art animations
Apache License 2.0
3.64k stars 238 forks source link

Added new typewriter effect #264

Closed mjip closed 3 years ago

mjip commented 4 years ago

Issues fixed by this PR

Closes #263

What does this implement/fix?

Any other comments?

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.02%) to 97.329% when pulling 651134ba9460c0432d71bb07c615b99969f63c19 on mjip:left-to-right-effect into 476159c95c5b6e34a782ea97503785ad95683805 on peterbrittain:master.

peterbrittain commented 4 years ago

Thanks. I just tried running it live and it didn't do what I expected... I think there are a couple of bugs and some possible improvements we could make here. I'll try to add some comments to the code to explain.

peterbrittain commented 4 years ago

Hope that all makes sense... Do you think you can make those changes?

mjip commented 4 years ago

For sure. Document the issues you see here, and I'll try writing up some more extensive examples to look at on my end (I was using a SpeechBubble static renderer)

peterbrittain commented 4 years ago

Thanks. Detailed comments are in the review. Main bug I saw was that the first column of text was offset from the rest on my test. Hope that helps!

mjip commented 4 years ago

Thanks for taking the time to review! Only, I can't seem to find it- have you published it yet? This could also perhaps be one of the Github redesign's quirks

peterbrittain commented 4 years ago

@mjip Any luck with those changes?

mjip commented 4 years ago

I haven't had the time to take a look lately, but I'm hoping to revisit it next week. Thanks for the review though!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.