Change Frame to support scroll bars without a border

peterbrittain / asciimatics

A cross platform package to do curses-like operations, plus higher level APIs and widgets to create text UIs and ASCII art animations

Apache License 2.0

3.64k stars 238 forks source link

Change Frame to support scroll bars without a border #329

Closed cltrudeau closed 3 years ago

cltrudeau commented 3 years ago

Issues fixed by this PR

None

What does this implement/fix?

Frame can now support a scroll bar without rendering a border. Frame.has_border and Frame.can_scroll are now independent of each other. This is a breaking change: Frame(has_border=False) now needs to be Frame(has_border=False, can_scroll=False) to get the same effect)

Any other comments?

Updated Frame.move_to() to use self._canvas for consistency

coveralls commented 3 years ago

Coverage increased (+0.008%) to 97.077% when pulling 85e8f2ce0344a368eaf0e98efb1f2401798ecb4a on cltrudeau:border into 1fde70eeda8639e7b70b2d6e5bbf604c6acd64bf on peterbrittain:master.

cltrudeau commented 3 years ago

Ok @peterbrittain I think this one is good to go