Gaplayout

[cltrudeau]

What does this implement/fix?

Adds ability to specify a gutter between columns in the Layout object

Any other comments?

Bunch of stuff:

• The reason I built this was because my custom widget was taking up the entire column. I'm not sure if this is best practice or not. I noticed when I built the test cases using a TextBox, that the default layout was already leaving a single character gap between the columns... which I suspect was being put there by the TextBox itself? Adding a gutter parm of 3 meant the actual gap between the columns becomes 4. Not sure what is the best approach here, could be just that my own widget really had a bug in it, and in that case spec'ing "gutter=3" should turn into an extra 2 space?
• I went with "gutter" rather than "gap" as "gap" is used internally in the comments and I didn't want it to be confused
• I did a small re-factor on the assert_canvas_equal() helper function so that the canvas -> text was in its own function. It makes it easier to print the result to the screen when you're trying to figure out what is going on
• nosetests appear to be failing with Python 3.11, I down switched to Python 3.9. Something to do with the fact that they moved the Collections.abc.Callable class
• The test for the image renderer is failing, but I suspect that's a Pillow version thing. I was unable to install the pinned version of Pillow due to some weirdness with zlib being not found even though it was actually there. I double checked and none of the code I touched is invoked by that test, so I'm assuming it wasn't my fault :)
• I see the occasional comment in the code about the "2.0" version, you going to drop Python 2.7 when you go there?

[peterbrittain]

Sorry for the slow reply. Bunch of responses... :-)

• Gutter logic looks good - just some comments on the tests. Do you want to do the Readbox as part of this commit or the other?
• I don't believe that any widget deliberately leaves an extra gap on the layout... They should all fill the specified column. Is it an integer rounding issue?
• i need to look at nosetest at some point. May have to drop tty testing if I can't fix that...
• Yeah - Pillow changes its algorithms and so breaks image rendering tests unless you use the pinned dev version.
• Yeah - I plan to drop 2.7 support in the next major update.

[cltrudeau]

Gutter logic looks good - just some comments on the tests. Do you want to do the Readbox as part of this commit or the other?

Yeah, looks like I screwed up and put them in the same branch, which means the second PR includes the changes from the first. This is what happens when you don't code for other people much anymore :)

Do whatever is easiest to compensate for my mistake, either all in one or separate.

[peterbrittain]

Yeah, looks like I screwed up and put them in the same branch, which means the second PR includes the changes from the first. This is what happens when you don't code for other people much anymore :)

Happens to me all the time outside of this project! :-) Let's break out ReadBox. I still want to think a little more on how best to integrate that.

[cltrudeau]

Sure. What's easiest? Want me to create a new PR, or is there something you can do to pick out the file changes?

[peterbrittain]

I've cherry picked and merged manually.