Closed cltrudeau closed 1 year ago
Sorry for the slow reply. Bunch of responses... :-)
Gutter logic looks good - just some comments on the tests. Do you want to do the Readbox as part of this commit or the other?
Yeah, looks like I screwed up and put them in the same branch, which means the second PR includes the changes from the first. This is what happens when you don't code for other people much anymore :)
Do whatever is easiest to compensate for my mistake, either all in one or separate.
Yeah, looks like I screwed up and put them in the same branch, which means the second PR includes the changes from the first. This is what happens when you don't code for other people much anymore :)
Happens to me all the time outside of this project! :-) Let's break out ReadBox. I still want to think a little more on how best to integrate that.
Sure. What's easiest? Want me to create a new PR, or is there something you can do to pick out the file changes?
I've cherry picked and merged manually.
What does this implement/fix?
Adds ability to specify a gutter between columns in the Layout object
Any other comments?
Bunch of stuff: