search

peterbsmyth / ngx-breadcrumbs

Angular 4+ routing breadcrumbs
MIT License
59 stars 43 forks source link

Update to Angular 6 RXJS 6 #21

Open hamzamensi opened 6 years ago

hamzamensi commented 6 years ago

please merge it

peterbsmyth commented 6 years ago

We needed to use this PR so we published an npm package called 'ngx-breadcrumbs-ui'. If you are using ngx-breadcrumbs with angular six you can swap the npm dependencies and fix your app with this work-around.

jpargana commented 6 years ago

Hi @peterbsmith2. Thanks for your workaround. I tried to put your npm module working and everything work fine in dev enviroment. But running ng build --prod, an error was happens. 

ERROR in ./node_modules/ngx-breadcrumbs-ui/ngx-breadcrumbs.ngfactory.js
Module not found: Error: Can't resolve 'ngx-breadcrumbs' in '[...]/node_modules/ngx-breadcrumbs-ui'

I tried to change "importAs":"ngx-breadcrumbs" to "importAs":"ngx-breadcrumbs-ui" in ngx-breadcrumbs.metadata.json and everything is working but i dont know if it is enough or if there are any other solution.

Thanks by advanced

peterbsmyth commented 6 years ago

@jpargana we are having the same issue now. and we are working on it. will keep you posted today.

peterbsmyth commented 6 years ago

@jpargana we incorporated your suggestion so the latest ngx-breadcrumbs-ui (0.0.10) ought to work fine.