peterbsmyth / ngx-breadcrumbs

Angular 4+ routing breadcrumbs
MIT License
59 stars 43 forks source link

Angular 6 #23

Closed HalaSalameh closed 5 years ago

HalaSalameh commented 6 years ago

when using npm install ngx-breadcrumbs , it installs the version for angular 5 when using npm install https://github.com/McNull/ngx-breadcrumbs.git to get the latest version , it saying there is no module called ngx-breadcrumbs when importing in the app . it also shows this error :
ERROR in node_modules/ngx-breadcrumbs/src/lib/mc-breadcrumbs/src/mc-breadcrumbs.shared.ts(22,27): error TS2307: Cannot find module 'lodash.template'. node_modules/ngx-breadcrumbs/src/lib/mc-breadcrumbs/src/mc-breadcrumbs.shared.ts(23,35): error TS2307: Cannot find module 'lodash.templatesettings'.

tomrainedotcom commented 6 years ago

Getting the same Error here too. ERROR in src/app/app.module.ts(10,37): error TS2307: Cannot find module 'ngx-breadcrumbs'.

peterbsmyth commented 6 years ago

This github package doesnt distribute the dist files. Those are only published to npm. Thats the reason for the error.

glebmachine commented 6 years ago

@McNull could you please publish ng6 version to npm?

tomadj commented 6 years ago

Yes me too, @McNull could you please publish ng6 version to npm? Thank's !

amelamel commented 6 years ago

could you please publish ng6 version to npm? Thank's !

thekiba commented 6 years ago

@McNull could you please publish ng6 version to npm?

qluqua commented 6 years ago

@McNull Hey sir, could you please publish ng6 version to npm? +1

sk8knut commented 6 years ago

@McNull could you please publish ng6 version to npm?

6matko commented 6 years ago

@McNull could you please publish ng6 version to npm?

meowhunter commented 6 years ago

@McNull could you please publish ng6 version to npm?

AlexDaSoul commented 6 years ago

@McNull could you please publish ng6 version to npm?

gun2rin commented 6 years ago

@McNull could you please publish ng6 version to npm?

splincode commented 6 years ago

@McNull could you please publish ng6 version to npm? :)

shishkinilya commented 6 years ago

@McNull could you please publish ng6 version to npm?

irustm commented 6 years ago

@McNull could you please publish ng6 version to npm? 🙂

ZeevKatz commented 6 years ago

@McNull could you please publish ng6 version to npm?

fire2 commented 6 years ago

@McNull any ETA when the ng6 version will be published?

McNull commented 5 years ago

Due to lake of time I'm not maintaining this library anymore. If someone is willing to fork and continue work on this module inform me about it and I'll update the README.md.

peterbsmyth commented 5 years ago

I understand the codebase because I forked it for angular 6. Will you transfer the repo to my ownership?

On Fri, Oct 26, 2018 at 6:31 AM McNull notifications@github.com wrote:

Closed #23 https://github.com/McNull/ngx-breadcrumbs/issues/23.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/McNull/ngx-breadcrumbs/issues/23#event-1928483673, or mute the thread https://github.com/notifications/unsubscribe-auth/AB39olWgZbRvxR_TTAP808WROKxAxUO2ks5uouRjgaJpZM4WMWge .

-- Sent from Gmail Mobile

peterbsmyth commented 5 years ago

Can you also transfer the npm repository to finish this?

On Fri, Oct 26, 2018 at 8:01 AM Peter Smith peterbutlersmith@gmail.com wrote:

I understand the codebase because I forked it for angular 6. Will you transfer the repo to my ownership?

On Fri, Oct 26, 2018 at 6:31 AM McNull notifications@github.com wrote:

Closed #23 https://github.com/McNull/ngx-breadcrumbs/issues/23.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/McNull/ngx-breadcrumbs/issues/23#event-1928483673, or mute the thread https://github.com/notifications/unsubscribe-auth/AB39olWgZbRvxR_TTAP808WROKxAxUO2ks5uouRjgaJpZM4WMWge .

-- Sent from Gmail Mobile

-- Sent from Gmail Mobile