search

petercerno / good-morning

Simple Python module for downloading fundamental financial data from financials.morningstar.com.
Other
189 stars 82 forks source link

Lots of requests without problems? #22

Open TravelTrader opened 4 years ago

TravelTrader commented 4 years ago

I have more a question than an issue:

  1. good_morning is the holy grail in my search for getting data from morningstar!

  2. I just use it for 1-5 stocks per day. And not at the same time at the moment.

But did you really use your demo of getting the data for 500 stocks of the S&P500? Isn't there a problem with requesting so much data? Or would you recommend adding a proxy server option?

Thanks for your opinions!

petercerno commented 4 years ago

Hi,

thanks your interest. I really appreciate that this old project is still useful to you. (I no longer have capacity to maintain it.)

If I remember correctly, I was able to get the data for 500 stocks by requesting them in a sequence with reasonable (random) delay. You need to try and see what works best for you.

Cheers,

Peter

On Mon, Nov 4, 2019 at 2:14 PM TravelTrader notifications@github.com wrote:

I have more a question than an issue:

1.

good_morning is the holy grail in my search for getting data from morningstar! 2.

I just use it for 1-5 stocks per day. And not at the same time at the moment.

But did you really use your demo of getting the data for 500 stocks of the S&P500? Isn't there a problem with requesting so much data? Or would you recommend adding a proxy server option?

Thanks for your opinions!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/petercerno/good-morning/issues/22?email_source=notifications&email_token=AAMSUOJI7FIXKIJQ7AH4BR3QSAN45A5CNFSM4JITLU52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWS745A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMSUOMHOLYEAZU2DSLIL5LQSAN45ANCNFSM4JITLU5Q .

TravelTrader commented 4 years ago

Yes, of course, it's very useful. I tried around before with the url from the source code but didn't get a good result. Therefore: It worked immediately. Thanks.

And with the requests you would say: Just do it until any problems happen?

petercerno commented 4 years ago

I think that you can try. In the worst case you get throttled / or blacklisted for an hour / day. Then you can slow down or increase the waiting intervals.

On Tue, Nov 5, 2019 at 5:24 PM TravelTrader notifications@github.com wrote:

Yes, of course, it's very useful. I tried around before with the url from the source code but didn't get a good result. Therefore: It worked immediately. Thanks.

And with the requests you would say: Just do it until any problems happen?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/petercerno/good-morning/issues/22?email_source=notifications&email_token=AAMSUOOOOH6KSRPPABPULP3QSGM4RA5CNFSM4JITLU52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDDJRKQ#issuecomment-549886122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMSUOLCLRSF3UU3Z5MY4ALQSGM4RANCNFSM4JITLU5Q .

jjphung commented 4 years ago

@TravelTrader this repo still works for you? I tried the basic example on the Readme, but it throws an error: MorningStar cannot find the ticker symbol you entered or it is INVALID. Please try again. I tried messing with the url in good_morning for a couple of hours, but to no avail.