peterchs / homebridge-dyson360eye

Homebridge plugin for the Dyson 360 Eye Robot Vacuum
MIT License
10 stars 3 forks source link

Great job! #1

Closed mczac closed 7 years ago

mczac commented 7 years ago

Awesome module! Just a small feature request, is it possible to post incremental status updates into the logs, rather than MQTT logs like: {"msg":"CURRENT-STATE","state":"INACTIVE_CHARGING","fullCleanType":"","cleanId":"","currentVacuumPowerMode":"fullPower","defaultVacuumPowerMode":"fullPower","globalPosition":[0,0],"batteryChargeLevel":90,"time":"2017-08-14T19:56:30Z"} Thanks!

peterchs commented 7 years ago

Thanks for the feedback! Had originally just dumped the logs for debugging but could print out the status updates and key changes without the json structure

mczac commented 7 years ago

Actually, this is really very minor, I might do it later. What happens when you have multiple Dyson devices the MQTT status update initiate log updates for other products like Fan.

peterchs commented 7 years ago

Not sure I follow. If you have two devices there should be two separate MQTT client objects which will subscribe/publish to each device on its own.

If you mean you want to watch the logs for different devices, should be possible to include the device username or some other identifier at the start of each log line.

Peter

On 14 August 2017 at 21:56, mczac notifications@github.com wrote:

Actually, this is really very minor, I might do it later. What happens when you have multiple Dyson devices the MQTT status update initiate log updates for other products like Fan.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/peteakalad/homebridge-dyson360eye/issues/1#issuecomment-322307298, or mute the thread https://github.com/notifications/unsubscribe-auth/AEipHeTHTao8PAqTFfwQZirxJNP9rabtks5sYLRpgaJpZM4O2ldC .

mczac commented 7 years ago

Sorry, my bad, I noticed that homebridge-dyson-link started to write MQTT status into the log today. I never noticed it before. Thought that your module was pulling all Dyson products update. Apologies. closing in now. thank you.