petercorke / robotics-toolbox-matlab

Robotics Toolbox for MATLAB
GNU Lesser General Public License v2.1
1.26k stars 440 forks source link

Fix Octave port #38

Open petercorke opened 5 years ago

petercorke commented 5 years ago

Get RTB 10.x working with Octave

petercorke commented 5 years ago

Good work by @gedeschaines ultimately to be integrated into RTB.

Some notes on what's currently broken when running with Octave.

gedeschaines commented 5 years ago

I just updated the following files in ./Octave/rvctools:

common/plot2.m robot/trplot.m robot/trplot2.m robot/utils/hgtransform.m

to address the problem using Octave 4.4.1 hgtransform on 2D and 3D plot lines in the trplot2 and trplot functions. The changes to these files are compatible with RTB v9.8 in MATLAB R2018b, but will break pose plotting in RTB v10. The updates do not address problem with hgtransform on text.

petercorke commented 5 years ago

Gary,

I’m chatting with somebody about hgtransform issues at

https://savannah.gnu.org/bugs/?50466 https://savannah.gnu.org/bugs/?50466

peter

On 14 Dec 2018, at 4:48 pm, Gary E. Deschaines notifications@github.com wrote:

I just updated the following files in ./Octave/rvctools https://github.com/gedeschaines/robotics-toolbox-python/tree/update1/Octave:

common/plot2.m robot/trplot.m robot/trplot2.m robot/utils/hgtransform.m

to address the problem using Octave 4.4.1 hgtransform on 2D and 3D plot lines in the trplot2 and trplot functions. The changes to these files are compatible with RTB v9.8 in MATLAB R2018b. The updates do not address problem with hgtransform on text.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/petercorke/robotics-toolbox-matlab/issues/38#issuecomment-447232135, or mute the thread https://github.com/notifications/unsubscribe-auth/ALQUUvh_sER9GXlgmNLbcdy3K8zZmEfjks5u40m9gaJpZM4ZCMQW.

gedeschaines commented 5 years ago

Peter,

To put it succinctly, an hgtransform 'parent' property/value pair passed as arguments in line(), plot() and plot3() functions are interpreted by Octave's libinterp/corefnc/graphics routines as an hggroup 'parent' property/value pair; consequently not producing the desired results. I have sent you an email with a detailed explanation of the bug #50466 issue.

Gary

On Sat, Dec 15, 2018 at 7:50 PM Peter Corke notifications@github.com wrote:

Gary,

I’m chatting with somebody about hgtransform issues at

https://savannah.gnu.org/bugs/?50466 <https://savannah.gnu.org/bugs/?50466

peter

On 14 Dec 2018, at 4:48 pm, Gary E. Deschaines notifications@github.com wrote:

I just updated the following files in ./Octave/rvctools < https://github.com/gedeschaines/robotics-toolbox-python/tree/update1/Octave :

common/plot2.m robot/trplot.m robot/trplot2.m robot/utils/hgtransform.m

to address the problem using Octave 4.4.1 hgtransform on 2D and 3D plot lines in the trplot2 and trplot functions. The changes to these files are compatible with RTB v9.8 in MATLAB R2018b. The updates do not address problem with hgtransform on text.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/petercorke/robotics-toolbox-matlab/issues/38#issuecomment-447232135>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ALQUUvh_sER9GXlgmNLbcdy3K8zZmEfjks5u40m9gaJpZM4ZCMQW .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/petercorke/robotics-toolbox-matlab/issues/38#issuecomment-447611390, or mute the thread https://github.com/notifications/unsubscribe-auth/Adqf6-Kk-df-nlJi7P6LB9B_vhxkBytJks5u5ab7gaJpZM4ZCMQW .

petercorke commented 5 years ago

Thanks for posting this on savannah, let’s see what Rik5 says.

On 18 Dec 2018, at 1:53 am, Gary E. Deschaines notifications@github.com wrote:

Peter,

To put it succinctly, an hgtransform 'parent' property/value pair passed as arguments in line(), plot() and plot3() functions are interpreted by Octave's libinterp/corefnc/graphics routines as an hggroup 'parent' property/value pair; consequently not producing the desired results. I have sent you an email with a detailed explanation of the bug #50466 issue.

Gary

On Sat, Dec 15, 2018 at 7:50 PM Peter Corke notifications@github.com wrote:

Gary,

I’m chatting with somebody about hgtransform issues at

https://savannah.gnu.org/bugs/?50466 <https://savannah.gnu.org/bugs/?50466

peter

On 14 Dec 2018, at 4:48 pm, Gary E. Deschaines notifications@github.com wrote:

I just updated the following files in ./Octave/rvctools < https://github.com/gedeschaines/robotics-toolbox-python/tree/update1/Octave :

common/plot2.m robot/trplot.m robot/trplot2.m robot/utils/hgtransform.m

to address the problem using Octave 4.4.1 hgtransform on 2D and 3D plot lines in the trplot2 and trplot functions. The changes to these files are compatible with RTB v9.8 in MATLAB R2018b. The updates do not address problem with hgtransform on text.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/petercorke/robotics-toolbox-matlab/issues/38#issuecomment-447232135>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ALQUUvh_sER9GXlgmNLbcdy3K8zZmEfjks5u40m9gaJpZM4ZCMQW .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/petercorke/robotics-toolbox-matlab/issues/38#issuecomment-447611390, or mute the thread https://github.com/notifications/unsubscribe-auth/Adqf6-Kk-df-nlJi7P6LB9B_vhxkBytJks5u5ab7gaJpZM4ZCMQW .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/petercorke/robotics-toolbox-matlab/issues/38#issuecomment-447893863, or mute the thread https://github.com/notifications/unsubscribe-auth/ALQUUogW56DPgXYVzCAHA7EoOUsqM6dGks5u573jgaJpZM4ZCMQW.