petercorke / robotics-toolbox-matlab

Robotics Toolbox for MATLAB
GNU Lesser General Public License v2.1
1.29k stars 444 forks source link

The GUI tool pull request. #68

Open borninfreedom opened 4 years ago

borninfreedom commented 4 years ago

Hello, author , I used Matlab robotics toolbox to make this GUI, https://github.com/borninfreedom/matlab-robotics-GUI-tool. It is convenient for users who are accustomed to using GUI. Can you merge this GUI into your project ?

petercorke commented 4 years ago

Hi Eric,

it’s an impressive piece of work and thanks for sharing it with me. A few comments:

peter

On 28 Nov 2019, at 8:38 am, Eric Wen notifications@github.com wrote:

Hello, I used Matlab robotics toolbox to make this GUI, https://blog.csdn.net/bornfree5511/article/details/103299633 https://blog.csdn.net/bornfree5511/article/details/103299633. It is convenient for users who are accustomed to using GUI. Project address: https://github.com/borninfreedom/robotics_arm/tree/master/RobotStudio https://github.com/borninfreedom/robotics_arm/tree/master/RobotStudio. Can you merge this GUI into your project ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/petercorke/robotics-toolbox-matlab/issues/68?email_source=notifications&email_token=AC2BIUXOFXR5H7TTKJ7U6UTQV6UTPA5CNFSM4JSTIQU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4VBDDA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2BIUTQWRO2AMAK6TPSJVDQV6UTPANCNFSM4JSTIQUQ.

-- Peter Corke Robotics, Vision & Control, 2nd edition Robotics Toolbox for MATLAB Machine Vision Toolbox for MATLAB at http://www.petercorke.com

borninfreedom commented 4 years ago

Hi, author.

petercorke commented 4 years ago

On 3 Dec 2019, at 8:45 am, Eric Wen notifications@github.com wrote:

Hi, author.

the project is totally based on matlab robotics toolbox. thanks, but that wasn’t really my point. The framework in which you created the GUI is obsolete, app designer is the current one. It has many advantages but also some limitations, see https://www.mathworks.com/products/matlab/app-designer.html

I’m unwilling to add something based on obsolete technology to the toolbox.

I think many of your questions are because you don't understand Chinese. I will look at app builder and try to re-write the code if I have time. If I do that, I will provide English version. This raises the bigger issue about language localisation for MATLAB code, I found

https://blogs.mathworks.com/community/2009/05/04/internationalization-of-guis/

I will refine the definition of the axes. Sorry, I don't handle the arm configuration yet, thanks for your reminder, I will refine it. Thank you for your reply. — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/petercorke/robotics-toolbox-matlab/issues/68?email_source=notifications&email_token=AC2BIURCW2PCQRJOG5YFW2TQWZBHBA5CNFSM4JSTIQU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFZDDVA#issuecomment-561131988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2BIUSQBPTHNCGIF2FFNVLQWZBHBANCNFSM4JSTIQUQ.

borninfreedom commented 4 years ago

Thank you very much for your guidance, I learned a lot .

is this modelled on some other tool?