search

peterdemin / openai-cli

Command-line client for OpenAI APIs
MIT License
155 stars 30 forks source link

Improve functionality and performance #13

Closed ktevfik closed 1 week ago

ktevfik commented 3 weeks ago

Hello,

I have implemented some improvements to make the application more efficient and seamless. This is my first pull request in Python, and I look forward to your valuable feedback.

Best regards.

peterdemin commented 3 weeks ago

Thanks, I'll take a look on the weekend

peterdemin commented 2 weeks ago

Overall, the code looks pretty good for the first time 😉 I find this style of unit tests shallow and does not provide a good safety net, but I won't block the PR on it. Unfortunately, OpenAI rejects my credit card, and I ran out of credits, so I can't check the new version manually... And I haven't been using it for some time, because I kinda abandoned another project that relied on this. Which makes you the primary user and developer on the project 😆 I'll merge the changes and release the new major version once you're happy with it.

ktevfik commented 2 weeks ago

thanks for your reviews. i am going to do corrections asap.

ktevfik commented 2 weeks ago

Hi again, could you please review this when you're available? If it's okay, I'll update the README.md as well. @peterdemin

peterdemin commented 1 week ago

Thanks! This is great!

peterdemin commented 1 week ago

Released 1.0.0: https://pypi.org/project/openai-cli/1.0.0/