s_ref assertion in geometry

peterdsharpe / AeroSandbox

Aircraft design optimization made fast through modern automatic differentiation. Composable analysis tools for aerodynamics, propulsion, structures, trajectory design, and much more.

https://peterdsharpe.github.io/AeroSandbox/

MIT License

690 stars 111 forks source link

s_ref assertion in geometry #1

Closed chiefenne closed 4 years ago

chiefenne commented 4 years ago

Describe the bug In geometry.py the attribute s_ref asserts if only one wing is specified.

Expected behavior It seems that the comment is right, but the code does not reflect that. if len(self.wings) > 1: # If there is at least one wing should this be: if len(self.wings) > 0: # If there is at least one wing

Desktop (please complete the following information):

OS: Windows 10
Anaconda Python 3.7.x

peterdsharpe commented 4 years ago

Oh whoops - great catch! Thank you so much! :)

I've just committed the change - it should make it into the next release, which will come out shortly!