search

peterdsharpe / AeroSandbox

Aircraft design optimization made fast through modern automatic differentiation. Composable analysis tools for aerodynamics, propulsion, structures, trajectory design, and much more.
https://peterdsharpe.github.io/AeroSandbox/
MIT License
690 stars 111 forks source link

Validation test #11

Closed jonititan closed 4 years ago

jonititan commented 4 years ago

Is your feature request related to a problem? Please describe. What is your opinion on including a validation test case? That way solver accuracy can be displayed and tests can be added to cover new features as they are added.

Describe the solution you'd like I will write an example next week for PR if you will consider. I will also include an airfoil file load method as listed in task https://github.com/peterdsharpe/AeroSandbox/projects/2#card-23370502

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

peterdsharpe commented 4 years ago

Hey @jonititan,

A validation case is a great idea! That's kind of what I was hoping that /examples/vlm3_conventional.py would be, but there's probably a better way to implement a validation case.

And thank you so much for implementing an airfoil file load method!

Please let me know if there's anything I can help you with!

jonititan commented 4 years ago

Ok well I don't have the book you reference but between the Cranfield library and the internet I’m sure we can find a few validation cases. Creating a file load method makes it easier to add new test cases which is why I linked the two.

aqreed commented 4 years ago

Hello, there is an interesting test case that I am using for my own VLM code in "Aerodynamics for Engineers" by John J. Bertin and Michael L. Smith. You can find it in Ch. 7 "Incompressible Flow about Wings of Finite Span", example 7.2.

Hope this is useful to you.