Closed carsonwmoon closed 3 months ago
Thank you @carsonwmoon! This is indeed a bug, and caused by some recent changes in indexing that neglected to consider slice inputs to __getitem__()
methods.
Fixed by 99b3d67c77bd5ba6da16ac453b7a1b99e54e6d60, and adds unit test to catch this failure mode in the future. Will be released along with the next ASB update.
Thanks!
Bug Description / Observed Behavior
First off, this AeroSandbox library is amazing!! Secondly, a small issue. I'm just looking at tutorials now but in the
06 - 3D Aircraft Dynamics for Engine-Out Analysis.ipynb
file, running it cell by cell on my computer, and in the code section quoted below it gives the error listed below.It seems the error is due to
_DynamicsPointMassBaseClass.__getitem__(self, index: int)
not working/implemented for index parameters of typeslice
like was intended to be used in the notebook code. Perhaps this is something on my end, but since this tutorial file had worked before, perhaps there's something under the hood that has changed. And again, amazing work on this library! Very impressive stuff.Steps to Reproduce
I got a fresh download of the library, downloaded the
06 - 3D Aircraft Dynamics for Engine-Out Analysis.ipynb
andcessna152.py
files, and started running it cell by cell until I through the one listed, at which point it gives the error listed.Expected Behavior
I expected it to work and result in what the online copy has here
System Information
Other Information
Nope