search

peterdsharpe / AeroSandbox

Aircraft design optimization made fast through modern automatic differentiation. Composable analysis tools for aerodynamics, propulsion, structures, trajectory design, and much more.
https://peterdsharpe.github.io/AeroSandbox/
MIT License
690 stars 111 forks source link

Units #4

Closed jonititan closed 4 years ago

jonititan commented 4 years ago

Nice project. I noticed your note re SI units

One final point to note: as we're all sensible and civilized human beings here, all inputs and outputs to AeroSandbox are expressed in base metric units (meters, Newtons, kilograms, etc.).

So may I take it that velocity is in m/s? If I wrote a pull request going through and annotating the docstrings to reflect would that be ok?

peterdsharpe commented 4 years ago

Thank you, and I hope the code is helpful to you! :) Yes - velocity is in m/s!

A pull request for annotating docstrings would be greatly appreciated - thank you so much for your contributions!

peterdsharpe commented 4 years ago

Hey Jonititan, just wanted to check in and see how this was going!

jonititan commented 4 years ago

Hopefully have a chance to get to this tonight or tomorrow.

Also thinking there might be some interesting other bits.

I'll write them up as feature requests perhaps and I can write branches for them after.

On Tue, 6 Aug 2019, 19:03 Peter Sharpe, notifications@github.com wrote:

Hey Jonititan, just wanted to check in and see how this was going!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/peterdsharpe/AeroSandbox/issues/4?email_source=notifications&email_token=AB3T4MWNAICQKXPQPCAAZHLQDG4HPA5CNFSM4IIVDZMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3V7HBI#issuecomment-518779781, or mute the thread https://github.com/notifications/unsubscribe-auth/AB3T4MQVAFT7MUTE4ZGJB6LQDG4HPANCNFSM4IIVDZMA .

peterdsharpe commented 4 years ago

Awesome - thanks so much for your first few pull requests! I merged them, they look great!

By the way, please consider starring the repo if you're interested in it! :)

peterdsharpe commented 4 years ago

Just got home and had a chance to look at your "Wild Turkey" example - looks sweet!