pytest is required but not included

peterdsharpe / AeroSandbox

Aircraft design optimization made fast through modern automatic differentiation. Composable analysis tools for aerodynamics, propulsion, structures, trajectory design, and much more.

https://peterdsharpe.github.io/AeroSandbox/

MIT License

690 stars 111 forks source link

pytest is required but not included #42

Closed bismurphy closed 3 years ago

bismurphy commented 3 years ago

Bug Description

Steps to Reproduce

Install Aerosandbox Attempt to run the simple_example.py in the examples directory on this repo

Expected Behavior

Script running. But it says I don't have pytest. I believe this is from aerosandbox importing Opti, and then opti importing pytest.

System Information

Operating System: Ubuntu 20.04.2
Python Version: 3.8.5
AeroSandbox Verion: Unknown, but just installed from pip yesterday.

Other Information

Christophe-Foyer commented 3 years ago

@peterdsharpe I think this has to do with this line in opti.py. Should probably test for this since I imagine the test environment installs pytest independently.

https://github.com/peterdsharpe/AeroSandbox/blob/3596989924c96b480d8d5103fccfc04e90de45c1/aerosandbox/optimization/opti.py#L4

For now as a quick fix you can just install pytest ('pip install pytest'), but this issue should be corrected as it shouldn't be required.

Christophe-Foyer commented 3 years ago

Should be addressed by this hotfix once it's merged: https://github.com/peterdsharpe/AeroSandbox/pull/43

peterdsharpe commented 3 years ago

Hey @tj-murphy, thanks for the bug report!

@Christophe-Foyer is spot on with his find and put together a perfect hotfix - it's been reviewed and merged. Thanks Christophe! :)

Closing this issue; please let us know if import problems continue!