peterdsharpe / AeroSandbox

Aircraft design optimization made fast through modern automatic differentiation. Composable analysis tools for aerodynamics, propulsion, structures, trajectory design, and much more.
https://peterdsharpe.github.io/AeroSandbox/
MIT License
687 stars 111 forks source link

Wrong requirements when installing via pip #66

Closed hughjward closed 2 years ago

hughjward commented 2 years ago

Bug Description

I believe the requirements file is out of date on PyPi

Steps to Reproduce

Tried to run tutorial 04 - Geometry and Data Structures/01 - AeroSandbox Data Structures/

ModuleNotFoundError: No module named 'pyvista'

Expected Behavior

Image of geometry should be created

System Information

Other Information

when running 'pip show aerosandbox' pyvista is not listed in the requirements

if i install pyvista separately (via pip) the image is created

peterdsharpe commented 2 years ago

Hi Hugh,

Please install AeroSandbox with the all optional dependencies (including PyVista) by running

pip install aerosandbox[full]

Without the full suffix, only a core version is installed, in order to minimize dependencies.

hughjward commented 2 years ago

Ah i didn't know PyPi had this functionality, and I also just read the PyPi project page properly!

Sorry to waste your time! 🙄

peterdsharpe commented 2 years ago

No worries!