search

peterdsharpe / AeroSandbox

Aircraft design optimization made fast through computational graph transformations (e.g., automatic differentiation). Composable analysis tools for aerodynamics, propulsion, structures, trajectory design, and much more.
https://peterdsharpe.github.io/AeroSandbox/
MIT License
761 stars 126 forks source link

Importing aerosandbox.library.airfoils raises warnings #73

Closed msberk closed 2 years ago

msberk commented 2 years ago

Bug Description

When importing aerosandbox.library.airfoils warnings are raised relating to the lack of coordinates available for the generic and flat plate airfoils.

Steps to Reproduce

>>> import aerosandbox.library.airfoils
C:\Users\MatthewBerk\git\DawnDesignTool\.venv\lib\site-packages\aerosandbox\library\airfoils.py:35: UserWarning: Airfoil Generic Cambered Airfoil had no coordinates assigned, and could not parse the `coordinates` input!
  generic_cambered_airfoil = Airfoil(
C:\Users\MatthewBerk\git\DawnDesignTool\.venv\lib\site-packages\aerosandbox\library\airfoils.py:47: UserWarning: Airfoil Generic Airfoil had no coordinates assigned, and could not parse the `coordinates` input!
  generic_airfoil = Airfoil(
C:\Users\MatthewBerk\git\DawnDesignTool\.venv\lib\site-packages\aerosandbox\library\airfoils.py:102: UserWarning: Airfoil Flat Plate had no coordinates assigned, and could not parse the `coordinates` input!
  flat_plate = Airfoil(

Expected Behavior

No output

System Information

Other Information

I suspect that the other airfoils in aerosandbox.library.airfoils get away with this by either being in the UIUC database or by being NACA, which both seem to have special handling in the aerosandbox.geometry.airfoil.Airfoil constructor. However 'generic' and 'flat_plate' airfoils do not have UIUC or NACA equivalents and aren't being found.

msberk commented 2 years ago

Added PR #74 to resolve this issue