search

peterdsharpe / AeroSandbox

Aircraft design optimization made fast through modern automatic differentiation. Composable analysis tools for aerodynamics, propulsion, structures, trajectory design, and much more.
https://peterdsharpe.github.io/AeroSandbox/
MIT License
687 stars 111 forks source link

Correcting Torenbeek #93

Closed Dirkjoost closed 1 year ago

Dirkjoost commented 1 year ago

I changed the torenbeek calculations a bit and split the functions for calculating the wing into wing basic structure, high lift and spoilers. The function for the wing mass can be called like before, but it adds the possibility to calculate the high lift and spoilers separately.

The Design_opt.py from transport aircraft i will be looking at the weight of the basic wing structure more in detail (will come).

Hope this works, had to learn a bit about git and how to provide new code. I will be walking through the stuff and see if I can help where needed.

peterdsharpe commented 1 year ago

Looks great - merged into aerosandbox/develop and will be included in the next AeroSandbox release, probably within the next few days! Thanks @Dirkjoost!

peterdsharpe commented 1 year ago

By the way, to act as a guide for future code contributions, it may be useful to review this "clean-up commit", which fixes several issues with this edit:

https://github.com/peterdsharpe/AeroSandbox/commit/08666e527f775c06dd7a2bdd7164089778d5fdad

Dirkjoost commented 1 year ago

Perfect! Thanks for your hints, will try to keep it clear and lean!