search

petere / homebrew-postgresql

🐘 PostgreSQL formulae for the Homebrew package manager
295 stars 34 forks source link

Fix deprecated devel blocks warning in formulae #55

Closed ogirginc closed 4 years ago

ogirginc commented 4 years ago

Searching for petere/postgresql kept showing depreciation warning. This PR fixes those warnings.

> brew search petere/postgresql
Warning: Calling 'devel' blocks in formulae is deprecated! Use 'head' blocks or @-versioned formulae instead.
Please report this issue to the petere/postgresql tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/petere/homebrew-postgresql/postgresql@13.rb:4

Warning: Calling 'devel' blocks in formulae is deprecated! Use 'head' blocks or @-versioned formulae instead.
Please report this issue to the petere/postgresql tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/petere/homebrew-postgresql/postgresql@8.4.rb:8

==> Formulae
petere/postgresql/postgresql-common ✔          petere/postgresql/postgresql@14                petere/postgresql/postgresql@9.2
petere/postgresql/postgresql@10                petere/postgresql/postgresql@8.3               petere/postgresql/postgresql@9.3
petere/postgresql/postgresql@11                petere/postgresql/postgresql@8.4               petere/postgresql/postgresql@9.4
petere/postgresql/postgresql@12                petere/postgresql/postgresql@9.0               petere/postgresql/postgresql@9.5
petere/postgresql/postgresql@13                petere/postgresql/postgresql@9.1               petere/postgresql/postgresql@9.6
petere commented 4 years ago

Is replacing devel with head the right fix? head should pull from git, not use a packaged tarball, no?

ogirginc commented 4 years ago

head should pull from git, not use a packaged tarball, no?

Hmm, turns out you are right! According to docs, head "allows installing software directly from a branch of a version-control repository".

Still, devel blocks are depreciated and needs to be replaced with something else. I have found this discussion. TBH, I am not sure, if I do like the suggested solution of creating additional formulaes for each pre-release versions.

All I can see is, there are two ways at this stage:

  1. Leave as it is and close the PR.
  2. Create PostgresqlAT13Beta1 formulae with stable block.

Which one would you prefer? Or do you have any other suggestions?