petere / homebrew-postgresql

🐘 PostgreSQL formulae for the Homebrew package manager
296 stars 34 forks source link

New postgresql.conf still has stats_temp_directory in new Postgres 16 instance #65

Open ijmorlan opened 5 months ago

ijmorlan commented 5 months ago

I was able to correct this by removing the stats_temp_directory setting from /usr/local/etc/postgresql-common/createcluster.conf. I'm not sure the best resolution of this; in the long run, I think it's clear stats_temp_directory should not be configured in the default createcluster.conf, but pre-16 versions are still current so it might be premature to remove it now. On the other hand, if I do a default installation and then use pg_createcluster to create a PG16 instance, it's surprising for it not start due to an obsolete setting in the newly-created postgresql.conf.

Regardless, I'm grateful for being able to use postgresql-common on Mac OS. I don't know how anybody can use PG for development without it.

hollyroberts commented 2 months ago

I had a similar issue at the time when PG15 came out (which removed the parameter). It was down to the version 189 in postgresql-common.rb which needed to be at least 241. Looking at the debian tracker stable is now 248 so maybe this just needs bumping, but I don't know what the extra effects will be. It's certainly a large increase of several years worth of changes.